Conversation
- Validates `days`, `initial_cash`, `initial_price`, and `volatility` arguments. - Prints descriptive error messages using `Colors.FAIL` (red) for better visibility. - Exits with status code 1 on validation failure. - Adds `test_cli.py` to verify CLI validation logic using subprocess. This improvement prevents confusing behavior (e.g., negative days resulting in empty simulations) and guides the user towards correct usage. Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Added input validation to the
bitcoin_trading_simulation.pyCLI to ensuredays,initial_cash,initial_price, andvolatilityare valid positive/non-negative numbers. This prevents confusing runtime behavior and provides helpful, color-coded error messages to the user. Also addedtest_cli.pyto verify these validations.PR created automatically by Jules for task 14435075941523167976 started by @EiJackGH